[chronik-client] Add prepublish command to prevent unbuilt npm deployments
ClosedPublic
Actions

Authored by bytesofman on Jul 17 2023, 04:19.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC24f691f35fda: [chronik-client] Add prepublish command to prevent unbuilt npm deployments

Summary

Depends on D14270

Package must be built before deployment. Adding 'prepublish' command so that npm publish will build the package before publishing.

Test Plan

Confirm spelling of "prepublish" and that npm run build builds the package

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Jul 17 2023, 04:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 17 2023, 04:19

bytesofman requested review of this revision.Jul 17 2023, 04:19

Harbormaster completed remote builds in B24506: Diff 41458.Jul 17 2023, 04:19

A few more things to consider before getting this in.

None of the other packages in the monorepo use yarn, make sure yarn is not in this package, unless it needs to be
Probably also want to run the tests before publishing

bytesofman edited the summary of this revision. (Show Details)Jul 17 2023, 04:22

bytesofman added a parent revision: D14270: [chronik-client] Bump version number.

bytesofman mentioned this in D14270: [chronik-client] Bump version number.

remove version bump

Harbormaster completed remote builds in B24521: Diff 41481.Jul 17 2023, 22:46

Remove version bump

This should be added to CI. However, it's still worth adding this here for now, to prevent any accidental publishing without first running npm run build. This step will be required in eventual CI add.

emack mentioned this in D14257: [Chronik-client] Implement new UTXO APIs.Jul 18 2023, 06:15

Getting cherry pick failures, probably needs rebase after D14270 landed yesterday