Page MenuHomePhabricator
Differential D14318

[Cashtab][Alias] Deprecate isAliasRegistered
ClosedPublic
Actions

Authored by emack on Jul 28 2023, 14:40.

Details

Reviewers
bytesofman
Fabien
Group Reviewers
Restricted Project
Commits
rABCf53a1c6d79ef: [Cashtab][Alias] Deprecate isAliasRegistered
Summary

T3216

Depends on D14317

Following the D14211 refactor, isAliasRegistered is no longer in use.

Test Plan

grep -r isAliasRegistered src/
npm test
Enable alias flag in Ticker.js
npm start
navigate to the Configure screen and ensure successful adding of contact using a valid alias and an error for invalid aliases (unregistered aliases will be handled in a separate diff - see T3216)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
isAliasAvailableDep
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24611
Build 48819: Build Diffcashtab-tests
Build 48818: arc lint + arc unit

Event Timeline

emack created this revision.Jul 28 2023, 14:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 28 2023, 14:40
emack requested review of this revision.Jul 28 2023, 14:40
Fabien requested changes to this revision.Jul 28 2023, 14:41
Fabien added a subscriber: Fabien.
Fabien added inline comments.
cashtab/src/components/Configure/Configure.js
1221–1222
This revision now requires changes to proceed.Jul 28 2023, 14:41
Harbormaster completed remote builds in B24611: Diff 41614.Jul 28 2023, 14:42
emack updated this revision to Diff 41615.Jul 28 2023, 14:49
emack marked an inline comment as done.

Simplified contact address alias validation

Harbormaster completed remote builds in B24612: Diff 41615.Jul 28 2023, 14:52
Fabien accepted this revision.Jul 28 2023, 15:18
This revision is now accepted and ready to land.Jul 28 2023, 15:18
Closed by commit rABCf53a1c6d79ef: [Cashtab][Alias] Deprecate isAliasRegistered (authored by emack). · Explain WhyJul 28 2023, 15:40
This revision was automatically updated to reflect the committed changes.
emack added a commit: rABCf53a1c6d79ef: [Cashtab][Alias] Deprecate isAliasRegistered.
emack mentioned this in D14324: [Cashtab][Alias] Add alias status check to wallet contacts.Jul 29 2023, 15:50
emack mentioned this in rABC0130850f2a1d: [Cashtab][Alias] Add alias status check to wallet contacts.Aug 3 2023, 13:56

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Configure/
10 lines
utils/
__tests__/
37 lines
13 lines

Diff 41614

View Options

cashtab/src/components/Configure/Configure.js

Loading...
View Options

cashtab/src/utils/__tests__/chronik.test.js

Loading...
View Options

cashtab/src/utils/chronik.js

Loading...