Differential D1436

A pack of nits in merkleblock.{h|cpp}
ClosedPublic
Actions

Authored by deadalnix on May 22 2018, 14:01.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING1a0afe542f5b: A pack of nits in merkleblock.{h|cpp}
rABC1a0afe542f5b: A pack of nits in merkleblock.{h|cpp}

Summary

Reformat comment, use early bail and C++11 loops.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.May 22 2018, 14:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2018, 14:01

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Also do serialization function

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2608: Diff 3929.May 22 2018, 14:38

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2609: Diff 3930.May 22 2018, 14:50

deadalnix added a child revision: D1437: Use TxId in CMerkleBlock.May 22 2018, 19:53

jasonbcox added a subscriber: jasonbcox.May 23 2018, 00:59

jasonbcox added inline comments.

src/merkleblock.cpp
21 ↗	(On Diff #3930)	This could use a range loop.

jasonbcox requested changes to this revision.May 23 2018, 01:06

This revision now requires changes to proceed.May 23 2018, 01:06

deadalnix requested review of this revision.May 23 2018, 10:00

deadalnix added inline comments.

src/merkleblock.cpp
21 ↗	(On Diff #3930)	No, there is a make_pair using the index.

jasonbcox accepted this revision.May 23 2018, 15:38

jasonbcox added inline comments.

src/merkleblock.cpp
21 ↗	(On Diff #3930)	err. missed that

This revision is now accepted and ready to land.May 23 2018, 15:38

Closed by commit rABC1a0afe542f5b: A pack of nits in merkleblock.{h|cpp} (authored by deadalnix). · Explain WhyMay 23 2018, 16:01

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

merkleblock.h

32 lines

merkleblock.cpp

126 lines

Diff 3949

View Options

src/merkleblock.h