Page MenuHomePhabricator
Differential D1437

Use TxId in CMerkleBlock
ClosedPublic
Actions

Authored by deadalnix on May 22 2018, 16:55.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING62a5d0524bfe: Use TxId in CMerkleBlock
rABC62a5d0524bfe: Use TxId in CMerkleBlock
Summary

As per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 22 2018, 16:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2018, 16:55
teamcity added a subscriber: teamcity.May 22 2018, 16:57

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 22 2018, 17:33

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2610: Diff 3933.May 22 2018, 17:33
deadalnix added a parent revision: D1436: A pack of nits in merkleblock.{h|cpp}.May 22 2018, 19:53
deadalnix added a child revision: D1439: Use TxId in GetTransaction and AccessByTxid.May 22 2018, 19:59
jasonbcox requested changes to this revision.May 23 2018, 01:06
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/rpc/rawtransaction.cpp
292 ↗(On Diff #3933)

Use a range-based loop

This revision now requires changes to proceed.May 23 2018, 01:06
deadalnix requested review of this revision.May 23 2018, 10:00
deadalnix added inline comments.
src/rpc/rawtransaction.cpp
292 ↗(On Diff #3933)

univalue is not iterrable.

jasonbcox accepted this revision.May 24 2018, 02:07
This revision is now accepted and ready to land.May 24 2018, 02:07
Closed by commit rABC62a5d0524bfe: Use TxId in CMerkleBlock (authored by deadalnix). · Explain WhyMay 24 2018, 07:08
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
5 lines
rpc/
32 lines

Diff 3950

View Options

src/merkleblock.h

Loading...
View Options

src/merkleblock.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...