Page MenuHomePhabricator

[explorer] Fix ordering of paginated txs
ClosedPublic

Authored by Fabien on Aug 11 2023, 22:14.

Details

Reviewers
tobias_ruck
Group Reviewers
Restricted Project
Commits
rABC433bc46ad1c6: [explorer] Fix ordering of paginated txs
Summary

In a block containing more txs than the max number of rows, the navigated page is off by one.
This is due to the DataTable() structure that uses a 0-based index despite the query uses a "non-dev human" (aka 1-based) index.

Test Plan

Run the explorer locally and open page for block 000000000000000010f98603f06c377d7148a34806343ac3d7fa9e4346556ce3. Check the tx pagination works as expected.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
explorer_tx_pagination
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24746
Build 49084: Build Diff
Build 49083: arc lint + arc unit