Details

Reviewers

tobias_ruck
Fabien

Group Reviewers

Restricted Project
Restricted Owners Package	(Owns No Changed Paths)

Commits

rABCb5a49c46dc7d: [chronik] Keep required Rust version in one place

Summary

Set required Rust version on the workspace level and inherit that in all packages.

Test Plan

mkdir buildChronik && cd buildChronik
cmake -GNinja .. -DBUILD_BITCOIN_CHRONIK=ON
ninja all check-crates
./test/functional/test_runner.py chronik_*

Diff Detail

Repository

rABC Bitcoin ABC

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24762
Build 49116: Build Diff	build-chronik
Build 49115: arc lint + arc unit

Event Timeline

osoftware created this revision.Aug 14 2023, 19:09

Owners added a reviewer: Restricted Owners Package.Aug 14 2023, 19:09

osoftware requested review of this revision.Aug 14 2023, 19:09

Harbormaster completed remote builds in B24762: Diff 41819.Aug 14 2023, 19:25

Please also align the version in bitcoinsuite-core, bitcoinsuite-slp and chronik-bridge Cargo.toml files. After that we should try to have all this in a single place

This revision now requires changes to proceed.Aug 15 2023, 11:07

Updating D14378: [chronik] Bump Rust version check in Chronik build

Keep required Rust version in one place

Harbormaster completed remote builds in B24775: Diff 41834.Aug 16 2023, 18:59

Updating D14378: [chronik] Bump Rust version check in Chronik build

Harbormaster completed remote builds in B24776: Diff 41835.Aug 16 2023, 19:31

Fabien accepted this revision.Aug 16 2023, 19:32

This revision is now accepted and ready to land.Aug 16 2023, 19:32

Can you update the title + commit message? The deeper telos now is to move the version to one place, not to set them to the same version (which is a nice side effect now). Otherwise good work

This revision now requires changes to proceed.Aug 16 2023, 20:37

osoftware retitled this revision from [chronik] Bump Rust version check in Chronik build to [chronik] Keep required Rust version in one place.Aug 18 2023, 20:49

osoftware edited the summary of this revision. (Show Details)

osoftware edited the test plan for this revision. (Show Details)

Updating D14378: Rephrasing commit messages

tobias_ruck accepted this revision.Aug 18 2023, 21:02

This revision is now accepted and ready to land.Aug 18 2023, 21:02

Harbormaster completed remote builds in B24795: Diff 41859.Aug 18 2023, 21:09

Closed by commit rABCb5a49c46dc7d: [chronik] Keep required Rust version in one place (authored by Tendo <--global>). · Explain WhyAug 19 2023, 14:57

This revision was automatically updated to reflect the committed changes.

Tendo <--global> added a commit: rABCb5a49c46dc7d: [chronik] Keep required Rust version in one place.