[electrum] access TxOutput value by attribute name rather than index in coinchooser
ClosedPublic
Actions

Authored by PiRK on Aug 28 2023, 15:33.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd10b4d3c45ef: [electrum] access TxOutput value by attribute name rather than index in…

Summary

TxOutput is a NamedTuple, which can be accessed by index or by attribute name. Accessing the fields by attribute name makes the code more readable.

Test Plan

python test_runner.py

Run the application, send a transaction to make sure the codepaths are triggered.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Aug 28 2023, 15:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 28 2023, 15:33

PiRK requested review of this revision.Aug 28 2023, 15:33

PiRK added a child revision: D14421: [electrum] remove "dust_to_fee" ephemeral value.

Harbormaster completed remote builds in B24875: Diff 41972.Aug 28 2023, 15:35

add typehints on touched methods to clarify that tx really has a tx.outputs() -> List[TXOutput] method

Harbormaster completed remote builds in B24878: Diff 41975.Aug 28 2023, 15:41

Fabien accepted this revision.Aug 29 2023, 07:29

This revision is now accepted and ready to land.Aug 29 2023, 07:29

Closed by commit rABCd10b4d3c45ef: [electrum] access TxOutput value by attribute name rather than index in… (authored by PiRK). · Explain WhyAug 29 2023, 08:34

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCd10b4d3c45ef: [electrum] access TxOutput value by attribute name rather than index in….

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

coinchooser.py

12 lines

Diff 41977

View Options

electrum/electrumabc/coinchooser.py

[electrum] access TxOutput value by attribute name rather than index in coinchooserClosedPublicActions