Page MenuHomePhabricator

[electrum] remove "dust_to_fee" ephemeral value
ClosedPublic

Authored by PiRK on Aug 28 2023, 15:35.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa73735e9ba5d: [electrum] remove "dust_to_fee" ephemeral value
Summary

This value is only needed in a GUI dialog which has all the data it needs to compute it. This removes some coupling between the GUI, transaction.py and coinchooser.py

As a result, methods in coinchooser.py no longer need to forward the dust_threshold constant to each other.

Add typehints and docstrings, and fix comments on touched functions. Remove a couple of debbuging prints.

Note that the unused dust_threshold parameter in CoinChooser.change_amounts is a relic of the original Electrum codebase which has a dust amount value that depends on the network congestion.

Depends on D14420

Test Plan

Run the application and send a transaction.

python test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable