Paths

Table of Contentst

Differential D14442

[electrum] fix sweep and add a test
ClosedPublic
Actions

Authored by PiRK on Sep 1 2023, 14:19.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCaab7dbb4e714: [electrum] fix sweep and add a test

Summary

D14436 broke the sweep function. Fix it, document it, and add a test to avoid future regressions.

Test Plan

python test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24929
Build 49446: Build Diff	electrum-tests
Build 49445: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 1 2023, 14:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 1 2023, 14:19

PiRK requested review of this revision.Sep 1 2023, 14:19

Harbormaster completed remote builds in B24929: Diff 42049.Sep 1 2023, 14:21

PiRK added a child revision: D14443: [electrum] let unittest discover all test cases.Sep 1 2023, 14:29

Fabien accepted this revision.Sep 1 2023, 21:32

This revision is now accepted and ready to land.Sep 1 2023, 21:32

Closed by commit rABCaab7dbb4e714: [electrum] fix sweep and add a test (authored by PiRK). · Explain WhySep 4 2023, 05:20

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCaab7dbb4e714: [electrum] fix sweep and add a test.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

tests/

test_wallet.py

120 lines

wallet.py

26 lines

Diff 42049

View Options

electrum/electrumabc/tests/test_wallet.py