Paths

Table of Contentst

Differential D14461

[electrum] implement TxInput.to_coin_dict and TxInput.is_complete
ClosedPublic
Actions

Authored by PiRK on Sep 8 2023, 10:49.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC46bf7431b80e: [electrum] implement TxInput.to_coin_dict and TxInput.is_complete

Summary

Move the serialization to the legacy dict format into TxInput

This opens the way to using TxInput internally in the Transaction class while still being able to convert to the legacy dict where it is really needed (saving coins to JSON)

Add tests related to input completeness (incomplete inputs have a value and a xpub)
Depends on D14459

Test Plan

python test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

deser_tx

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24980
Build 49548: Build Diff	electrum-tests
Build 49547: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 8 2023, 10:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 8 2023, 10:49

PiRK requested review of this revision.Sep 8 2023, 10:49

Harbormaster completed remote builds in B24980: Diff 42121.Sep 8 2023, 10:50

Fabien accepted this revision.Sep 11 2023, 08:23

This revision is now accepted and ready to land.Sep 11 2023, 08:23

PiRK mentioned this in D14466: [electrum] replace match_decoded function with more explicit functions.Sep 11 2023, 10:45

rebase

Harbormaster completed remote builds in B24990: Diff 42132.Sep 11 2023, 10:54

Closed by commit rABC46bf7431b80e: [electrum] implement TxInput.to_coin_dict and TxInput.is_complete (authored by PiRK). · Explain WhySep 12 2023, 10:48

This revision was automatically updated to reflect the committed changes.

PiRK mentioned this in rABC2673549a2fd8: [electrum] replace match_decoded function with more explicit functions.

PiRK added a commit: rABC46bf7431b80e: [electrum] implement TxInput.to_coin_dict and TxInput.is_complete.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

tests/

test_transaction.py

14 lines

transaction.py

138 lines

Diff 42121

View Options

electrum/electrumabc/tests/test_transaction.py