Page MenuHomePhabricator
Differential D14480

[Cashtab] Show total send amount in modal for one-to-many send txs
ClosedPublic
Actions

Authored by bytesofman on Sep 13 2023, 18:38.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC1217ef55d9d9: [Cashtab] Show total send amount in modal for one-to-many send txs
Summary

T2801

Show total amount of XEC user is about to send in a one-to-many tx in modal

Test Plan

npm test

Send a one-to-many tx with "Send Confirmations" enabled in settings. Verify total and formatting.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Sep 13 2023, 18:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2023, 18:38
bytesofman requested review of this revision.Sep 13 2023, 18:38
Harbormaster completed remote builds in B25018: Diff 42179.Sep 13 2023, 18:41
bytesofman added inline comments.Sep 13 2023, 18:42
cashtab/src/utils/cashMethods.js
558 ↗(On Diff #42179)

we can't use parseXecSendValue bc it is customized for tx creation and not rendering a string ... throws errors that crash the UI.

parseXecSendValue is also a dumb function that should be deprecated for other reasons, task open T3286

bytesofman updated this revision to Diff 42180.Sep 13 2023, 18:43

Improve function documentation

Harbormaster completed remote builds in B25019: Diff 42180.Sep 13 2023, 18:48
bytesofman planned changes to this revision.Sep 13 2023, 21:09

actually think it makes sense to deprecate parseXecSendValue in this diff as well

bytesofman added a child revision: D14481: [Cashtab] Deprecate parseXecSendValue.Sep 13 2023, 21:22
bytesofman requested review of this revision.Sep 13 2023, 21:22

nm better to stack it

emack requested changes to this revision.Sep 14 2023, 02:30
emack added a subscriber: emack.

image.png (296×558 px, 36 KB)

  1. 17.7 XEC total is being rounded down to 17, should be displayed as is up to the 2 decimal points.
  2. Minor nit, can use a newline before displaying the addresses.
This revision now requires changes to proceed.Sep 14 2023, 02:30
bytesofman updated this revision to Diff 42205.Sep 14 2023, 16:55

fix bug with decimal calcs, formatting improvements

Harbormaster completed remote builds in B25039: Diff 42205.Sep 14 2023, 16:59
emack accepted this revision.Sep 14 2023, 22:44
This revision is now accepted and ready to land.Sep 14 2023, 22:44
Closed by commit rABC1217ef55d9d9: [Cashtab] Show total send amount in modal for one-to-many send txs (authored by bytesofman). · Explain WhySep 14 2023, 23:08
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC1217ef55d9d9: [Cashtab] Show total send amount in modal for one-to-many send txs.

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Send/
24 lines
utils/
__tests__/
26 lines
16 lines

Diff 42215

View Options

cashtab/src/components/Send/Send.js

Loading...
View Options

cashtab/src/utils/__tests__/cashMethods.test.js

Loading...
View Options

cashtab/src/utils/cashMethods.js

Loading...