Paths

Table of Contentst

Differential D14492

[electrum] use Transaction.estimated_size() in consolidate.py
ClosedPublic
Actions

Authored by PiRK on Sep 15 2023, 15:14.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC6cd11f75e879: [electrum] use Transaction.estimated_size() in consolidate.py

Summary

This reduces the number of unnecessary serializations.
Depends on D14491

Test Plan

python test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25051
Build 49690: Build Diff	electrum-tests
Build 49689: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 15 2023, 15:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 15 2023, 15:14

PiRK requested review of this revision.Sep 15 2023, 15:14

Harbormaster completed remote builds in B25051: Diff 42225.Sep 15 2023, 15:15

rebase

Harbormaster completed remote builds in B25053: Diff 42227.Sep 15 2023, 15:19

bytesofman accepted this revision.Sep 15 2023, 19:27

This revision is now accepted and ready to land.Sep 15 2023, 19:27

Closed by commit rABC6cd11f75e879: [electrum] use Transaction.estimated_size() in consolidate.py (authored by PiRK). · Explain WhySep 16 2023, 09:07

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC6cd11f75e879: [electrum] use Transaction.estimated_size() in consolidate.py.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

consolidate.py

14 lines

tests/

test_consolidate.py

4 lines

Diff 42225

View Options

electrum/electrumabc/consolidate.py