[electrum] support coins with only x_pubkeys and no pubkeys defined
ClosedPublic
Actions

Authored by PiRK on Sep 18 2023, 10:50.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC0ab06e269919: [electrum] support coins with only x_pubkeys and no pubkeys defined

Summary

The wallet stores them like this. It is easy to compute a pubkey from an xpub + derivation, but let's do it lazily rather than do it in __init__ because it is not cheap and is only really needed when serializing or signing.

Test Plan

python test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 18 2023, 10:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 18 2023, 10:50

PiRK requested review of this revision.Sep 18 2023, 10:50

Harbormaster completed remote builds in B25061: Diff 42242.Sep 18 2023, 10:52

PiRK added a child revision: D14497: [electrum] move get_preimage_script from Transaction to TxInput.Sep 18 2023, 10:54

bytesofman added a subscriber: bytesofman.Sep 18 2023, 13:12

bytesofman added inline comments.

electrum/electrumabc/transaction.py
562 ↗	(On Diff #42242)	why is this conversion necessary? then the test case converts again to hex with `.hex(),`?

Fabien accepted this revision.Sep 18 2023, 13:40

This revision is now accepted and ready to land.Sep 18 2023, 13:40

PiRK added inline comments.Sep 18 2023, 13:54

electrum/electrumabc/transaction.py
562 ↗	(On Diff #42242)	So here I do the conversion from the legacy format (that is still used in other parts of the software) to new format. In tests, the conversions are mainly done so that the data is a bit more human-friendly to read and review (`"deadbeef"` vs `b"\xde\xad\xbe\xef"`). In the tests I don't care about performance, so using hex strings makes more sense.