Page MenuHomePhabricator
Differential D14509

[electrum] convert var_int to return bytes
ClosedPublic
Actions

Authored by PiRK on Sep 20 2023, 08:24.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa6316f3726f2: [electrum] convert var_int to return bytes
Summary

Some callsites already expect bytes, and the plan is to eventually only deal with bytes internally.

Test Plan

python test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
var_int
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25091
Build 49770: Build Diffelectrum-tests
Build 49769: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 20 2023, 08:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 20 2023, 08:24
PiRK requested review of this revision.Sep 20 2023, 08:24
Harbormaster completed remote builds in B25091: Diff 42285.Sep 20 2023, 08:26
Fabien accepted this revision.Sep 20 2023, 09:36
Fabien added a subscriber: Fabien.
Fabien added inline comments.
electrum/electrumabc/bitcoin.py
388

is int_to_le_hex still used after this diff ?

This revision is now accepted and ready to land.Sep 20 2023, 09:36
PiRK added inline comments.Sep 20 2023, 10:12
electrum/electrumabc/bitcoin.py
388

Yes, sadly there is still a lof of hex serialization happening that uses it for fixed length integers (amount, sequence.... in headers, transactions...)

Closed by commit rABCa6316f3726f2: [electrum] convert var_int to return bytes (authored by PiRK). · Explain WhySep 20 2023, 13:31
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCa6316f3726f2: [electrum] convert var_int to return bytes.
PiRK mentioned this in D14525: [electrum] consolidate compact_size code.Sep 22 2023, 14:23
PiRK mentioned this in rABCdcb410039d3e: [electrum] consolidate compact_size code.Sep 25 2023, 12:16

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
16 lines
tests/
24 lines
10 lines
electrumabc_plugins/
ledger/
4 lines
satochip/
2 lines

Diff 42285

View Options

electrum/electrumabc/bitcoin.py

Loading...
View Options

electrum/electrumabc/tests/test_bitcoin.py

Loading...
View Options

electrum/electrumabc/transaction.py

Loading...
View Options

electrum/electrumabc_plugins/ledger/ledger.py

Loading...
View Options

electrum/electrumabc_plugins/satochip/satochip.py

Loading...