Introduce a BlockStatus class to encapsulate CBlockIndex's validation status
ClosedPublic
Actions

Authored by deadalnix on May 24 2018, 12:06.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGfb384409f2d5: Introduce a BlockStatus class to encapsulate CBlockIndex's validation status
rABCfb384409f2d5: Introduce a BlockStatus class to encapsulate CBlockIndex's validation status

Summary

As per title.

Depends on D1445

Test Plan

make check

Added a unit test for the new class.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

blockstatusclass

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2631
Build 3376: Bitcoin ABC Buildbot (legacy)
Build 3375: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 24 2018, 12:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 24 2018, 12:06

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2631: Diff 3959.May 24 2018, 12:44

deadalnix added a child revision: D1451: Use hasData/hasUndo instead of masking with BLOCK_HAVE_DATA/BLOCK_HAVE_UNDO.May 24 2018, 12:51

schancel accepted this revision.May 24 2018, 19:07

This revision is now accepted and ready to land.May 24 2018, 19:07

Closed by commit rABCfb384409f2d5: Introduce a BlockStatus class to encapsulate CBlockIndex's validation status (authored by deadalnix). · Explain WhyMay 25 2018, 15:54

This revision was automatically updated to reflect the committed changes.

PiRK mentioned this in D8629: Convert chain and blockfileinfo to new serialization.Dec 8 2020, 14:27

PiRK mentioned this in rABC0b536d79fbb7: Convert chain and blockfileinfo to new serialization.Dec 8 2020, 19:39

Revision Contents
Changeset List

Path

Size

src/

Makefile.test.include

1 line

chain.h

84 lines

test/

CMakeLists.txt

1 line

blockstatus_tests.cpp

62 lines

Diff 3959

View Options

src/Makefile.test.include

View Options

src/chain.h

View Options

src/test/CMakeLists.txt

View Options

src/test/blockstatus_tests.cpp

Introduce a BlockStatus class to encapsulate CBlockIndex's validation statusClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 3959

src/Makefile.test.include

src/chain.h

src/test/CMakeLists.txt

src/test/blockstatus_tests.cpp

Introduce a BlockStatus class to encapsulate CBlockIndex's validation status
ClosedPublic
Actions

Revision Contents
Changeset List