Page MenuHomePhabricator
Differential D14517

[avalanche] Activate staking rewards on Nov. 15th, 2023
ClosedPublic
Actions

Authored by Fabien on Sep 21 2023, 11:45.

Details

Reviewers
bytesofman
PiRK
Group Reviewers
Restricted Project
Commits
rABCa75bfe47b9a8: [avalanche] Activate staking rewards on Nov. 15th, 2023
Summary

This enables the staking rewards rule on the cowperthwaite activation.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 21 2023, 11:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 21 2023, 11:45
Fabien requested review of this revision.Sep 21 2023, 11:45
Fabien changed the visibility from "Public (No Login Required)" to "Restricted Project (Project)".Sep 21 2023, 11:45
Harbormaster completed remote builds in B25115: Diff 42314.Sep 21 2023, 12:04
bytesofman added a subscriber: bytesofman.Sep 21 2023, 13:05

ninja all check-all

Is this run by teamcity?

src/node/miner.cpp
204 ↗(On Diff #42314)

Is adding this kind of param the usual way we roll out release-based changes? Does this mean we need a diff later to remove these conditions?

Fabien added a comment.Sep 21 2023, 13:57
In D14517#326035, @bytesofman wrote:

ninja all check-all

Is this run by teamcity?

Under several configs, and even with the next upgrade activated (see build-diff in the build configurations).

The builds that ran on this diff: build-without-wallet · lint-circular-dependencies · build-diff · build-debug · build-clang · build-clang-tidy

src/node/miner.cpp
204 ↗(On Diff #42314)

yes and yes

bytesofman accepted this revision.Sep 21 2023, 14:02
This revision is now accepted and ready to land.Sep 21 2023, 14:02
PiRK accepted this revision.Sep 22 2023, 06:19
Fabien added a child revision: D14604: [avalanche] Make the staking rewards activation chain dependent.Oct 5 2023, 11:24
Fabien updated this revision to Diff 42601.Oct 9 2023, 17:03

Rebase

Harbormaster completed remote builds in B25304: Diff 42601.Oct 9 2023, 17:38
Closed by commit rABCa75bfe47b9a8: [avalanche] Activate staking rewards on Nov. 15th, 2023 (authored by Fabien). · Explain WhyOct 9 2023, 20:26
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCa75bfe47b9a8: [avalanche] Activate staking rewards on Nov. 15th, 2023.
Fabien changed the visibility from "Restricted Project (Project)" to "Public (No Login Required)".Oct 9 2023, 20:26

Revision Contents
Changeset List

PathSize
doc/
7 lines
src/
avalanche/
2 lines
node/
3 lines
policy/
block/
12 lines
4 lines
rpc/
9 lines
3 lines
test/
functional/
75 lines
66 lines

Diff 42605

View Options

doc/release-notes.md

Loading...
View Options

src/avalanche/avalanche.h

Loading...
View Options

src/node/miner.cpp

Loading...
View Options

src/policy/block/stakingrewards.h

Loading...
View Options

src/policy/block/stakingrewards.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/functional/abc_mining_stakingrewards.py

Loading...
View Options

test/functional/abc_p2p_avalanche_policy_stakingrewards.py

Loading...