[electrum] start using tx.txinputs() in the wallet
ClosedPublic
Actions

Authored by PiRK on Sep 21 2023, 14:35.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC1007058b637b: [electrum] start using tx.txinputs() in the wallet

Summary

Convert all callsites from Transaction.inputs() to Transaction.txinputs(). The latter is less expensive as it does not require a dict building operation with hex conversions (especially when all we are interested in is len(tx.txinputs())

Depends on D14521

Test Plan

python test_runner.py

double-click on a transaction in the history to exercise get_wallet_delta

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25118
Build 49824: Build Diff	electrum-tests
Build 49823: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 21 2023, 14:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 21 2023, 14:35

PiRK requested review of this revision.Sep 21 2023, 14:35

Harbormaster completed remote builds in B25118: Diff 42324.Sep 21 2023, 14:38

PiRK edited the test plan for this revision. (Show Details)Sep 21 2023, 14:38

investigating a bug, not sure if related

PiRK mentioned this in D14521: [electrum] fix OutPoint.__str__.Sep 21 2023, 15:38

rebase onto D14521

Harbormaster completed remote builds in B25121: Diff 42327.Sep 21 2023, 15:45

PiRK edited the summary of this revision. (Show Details)Sep 21 2023, 15:45

PiRK added a parent revision: D14521: [electrum] fix OutPoint.__str__.

PiRK added inline comments.Sep 21 2023, 15:51

electrum/electrumabc/wallet.py
1449 ↗	(On Diff #42327)	I'm not sure why these vars are deleted. Maybe as a misguided garbage-collection optimization (it won't necessarily work unless `gc.collect` is called explicitly, which may actually slow down the function).

PiRK mentioned this in rABC75b8d794395d: [electrum] fix OutPoint.__str__.Sep 21 2023, 16:07

Fabien requested changes to this revision.Sep 22 2023, 07:23

Fabien added a subscriber: Fabien.

Fabien added inline comments.

electrum/electrumabc/wallet.py
810 ↗	(On Diff #42327)	I don't understand this. Because of the to_string() I expect both get to always fail and return the default ?
1449 ↗	(On Diff #42327)	My guess is that it used to be a "reset to null" to prevent reusing the values in the next loop iteration

This revision now requires changes to proceed.Sep 22 2023, 07:23

PiRK requested review of this revision.Sep 22 2023, 12:25

PiRK added inline comments.

electrum/electrumabc/wallet.py
810 ↗	(On Diff #42327)	`Wallet.txo` is a dict indexed by txid (as a hex string) whose values are dicts indexed by addresses containing lists of outputs for this txid and address.. `{txid: {address: [[prevout_n, amount, is_coinbase], ....], ... }, ...}` `outpoint.txid.to_string()` (`UInt256.to_string()`) from `TxInput` is the same as `coin["prevout_hash"]` from the legacy coin dict.