Paths

Table of Contentst

Differential D14533

[electrum] move new contact dialog to contact_list.py
ClosedPublic
Actions

Authored by PiRK on Sep 25 2023, 14:55.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC408eb1e67232: [electrum] move new contact dialog to contact_list.py

Summary

Move some code out of the main_window god object.
There is no change in behavior.

Depends on D14532

Test Plan

run ./electrum-abc, go to the contacts tab, right click and select "Add Contact - Address"
Fill the form (try both a valid and invalid address)

Redo the same test with the Wallet > Contacts > New menu

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 25 2023, 14:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 25 2023, 14:55

PiRK requested review of this revision.Sep 25 2023, 14:55

Harbormaster completed remote builds in B25155: Diff 42373.Sep 25 2023, 14:57

PiRK added a child revision: D14534: [electrum] move ElectrumWindow.set_contact method to ContactList.Sep 25 2023, 14:57

bytesofman accepted this revision.Sep 25 2023, 20:51

This revision is now accepted and ready to land.Sep 25 2023, 20:51

Closed by commit rABC408eb1e67232: [electrum] move new contact dialog to contact_list.py (authored by PiRK). · Explain WhySep 26 2023, 05:50

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC408eb1e67232: [electrum] move new contact dialog to contact_list.py.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc_gui/

qt/

contact_list.py

50 lines

main_window.py

26 lines

Diff 42382

View Options

electrum/electrumabc_gui/qt/contact_list.py