Differential D14534

[electrum] move ElectrumWindow.set_contact method to ContactList
ClosedPublic
Actions

Authored by PiRK on Sep 25 2023, 14:57.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC4e50fcdedc05: [electrum] move ElectrumWindow.set_contact method to ContactList

Summary

Remove more code from ElectrumWindow, just keep a signal/slot to let the main window update its other widgets.
There is no change in behavior.

Depends on D14533

Test Plan

same test plan as D14533, plus edit the contact name in the Contacts tab, close and reopen the wallet to verify the updated name is shown

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 25 2023, 14:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 25 2023, 14:57

PiRK requested review of this revision.Sep 25 2023, 14:57

PiRK edited the summary of this revision. (Show Details)Sep 25 2023, 14:58

Harbormaster completed remote builds in B25156: Diff 42374.Sep 25 2023, 14:59

PiRK added a child revision: D14535: [electrum] pass a wallet.contacts reference to ContactList.Sep 25 2023, 14:59

bytesofman accepted this revision.Sep 25 2023, 21:06

This revision is now accepted and ready to land.Sep 25 2023, 21:06

Closed by commit rABC4e50fcdedc05: [electrum] move ElectrumWindow.set_contact method to ContactList (authored by PiRK). · Explain WhySep 26 2023, 05:50

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC4e50fcdedc05: [electrum] move ElectrumWindow.set_contact method to ContactList.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc_gui/

qt/

contact_list.py

48 lines

main_window.py

40 lines

Diff 42381

View Options

electrum/electrumabc_gui/qt/contact_list.py