Paths

Table of Contentst

Differential D14570

[electrum] avoid unneccessary bytes <-> hex conversion for block header
ClosedPublic
Actions

Authored by PiRK on Oct 2 2023, 11:41.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC753bfdcd8b85: [electrum] avoid unneccessary bytes <-> hex conversion for block header

Summary

Make serialize_header return bytes to avoid converting to bytes at all callsites.

Depends on D14569

Test Plan

python test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 2 2023, 11:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2023, 11:41

PiRK requested review of this revision.Oct 2 2023, 11:41

Harbormaster completed remote builds in B25224: Diff 42477.Oct 2 2023, 11:43

PiRK added inline comments.Oct 2 2023, 11:47

electrum/electrumabc/blockchain.py
140 ↗	(On Diff #42477)	After that, rev_hex and int_to_le_hex are needed only in keystore.py (which still uses hex strings for keys)

bytesofman accepted this revision.Oct 2 2023, 14:01

This revision is now accepted and ready to land.Oct 2 2023, 14:01

Closed by commit rABC753bfdcd8b85: [electrum] avoid unneccessary bytes <-> hex conversion for block header (authored by PiRK). · Explain WhyOct 2 2023, 15:33

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC753bfdcd8b85: [electrum] avoid unneccessary bytes <-> hex conversion for block header.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

blockchain.py

30 lines

tests/

test_blockchain.py

6 lines

Diff 42487

View Options

electrum/electrumabc/blockchain.py