Paths

Table of Contentst

Differential D14567

[electrum] return bytes in tx.serialize_preimage()
ClosedPublic
Actions

Authored by PiRK on Oct 2 2023, 11:35.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC9560cd84ef8d: [electrum] return bytes in tx.serialize_preimage()

Summary

This is one of the last remaining places where data was serialized as a hex string in transaction.py

Test Plan

python test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 2 2023, 11:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2023, 11:35

PiRK requested review of this revision.Oct 2 2023, 11:35

Harbormaster completed remote builds in B25221: Diff 42474.Oct 2 2023, 11:36

PiRK added a child revision: D14568: [electrum] public_key_from_private_key return bytes.Oct 2 2023, 11:37

bytesofman accepted this revision.Oct 2 2023, 13:57

This revision is now accepted and ready to land.Oct 2 2023, 13:57

Closed by commit rABC9560cd84ef8d: [electrum] return bytes in tx.serialize_preimage() (authored by PiRK). · Explain WhyOct 2 2023, 15:33

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC9560cd84ef8d: [electrum] return bytes in tx.serialize_preimage().

PiRK mentioned this in D14613: [electrum] fix hardware wallets (except Trezor).Oct 9 2023, 07:14

PiRK mentioned this in rABCb7518269852e: [electrum] fix hardware wallets (except Trezor).Oct 9 2023, 18:22

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

transaction.py

46 lines

electrumabc_plugins/

digitalbitbox/

digitalbitbox.py

2 lines

fusion/

fusion.py

6 lines

server.py

6 lines

satochip/

satochip.py

9 lines

Diff 42484

View Options

electrum/electrumabc/transaction.py

View Options

electrum/electrumabc_plugins/digitalbitbox/digitalbitbox.py

View Options

electrum/electrumabc_plugins/fusion/fusion.py

View Options

electrum/electrumabc_plugins/fusion/server.py

View Options

electrum/electrumabc_plugins/satochip/satochip.py

[electrum] return bytes in tx.serialize_preimage()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42484

electrum/electrumabc/transaction.py

electrum/electrumabc_plugins/digitalbitbox/digitalbitbox.py

electrum/electrumabc_plugins/fusion/fusion.py

electrum/electrumabc_plugins/fusion/server.py

electrum/electrumabc_plugins/satochip/satochip.py

[electrum] return bytes in tx.serialize_preimage()
ClosedPublic
Actions

Revision Contents
Changeset List