Page MenuHomePhabricator

Lighten the net logging
ClosedPublic

Authored by Fabien on Oct 2 2023, 15:22.

Details

Reviewers
bytesofman
PiRK
Group Reviewers
Restricted Project
Commits
rABCf6bccb42a886: Lighten the net logging
Summary

Most of the logs from the net category are either errors/unusual behavior messages or important network event like version message, new block download etc.
The exception is the couple "received: " and "sending: " messages that log all the traffic in and out. It was OK until avalanche, and now it causes the log to be bloated by avapoll and avaresponse messages.

This diff creates a new log category "netdebug" that only contains these 2 messages for now, leaving the net logging almost identical but less bloated.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Oct 2 2023, 15:22
This revision is now accepted and ready to land.Oct 2 2023, 15:37

In the summary, it was OK since avalanche -> it was OK until avalanche?

In D14573#327324, @PiRK wrote:

In the summary, it was OK since avalanche -> it was OK until avalanche?

Indeed, good catch (fixed)

This revision was automatically updated to reflect the committed changes.