Page MenuHomePhabricator

[Cashtab] Deprecate airdrops
AbandonedPublic

Authored by bytesofman on Oct 2 2023, 21:50.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

Depends on D14577

SLPDB is well beyond its useful life. While it returned good results for the limited use case of getting token balances at addresses by blockheight, the airdrop feature was nice to have.

Unfortunately SLPDB has started returning haunted results (conflicting reports of balances that look off mixed with obviously wrong data). Occasionally no results are returned, though the server still returns a good status.

SLPDB was always slated for deprecation. Chronik does not yet support its full feature set, but it will be up to us to decide which features are indeed critical to revive and build out.

The Airdrop feature of Cashtab, like encrypted msgs, is high complexity and low use.

Test Plan

npm test

npm start and notice the airdrop screen is no longer in nav menu
npm run extension, open extension and confirm airdrop screen no longer in nav menu

Diff Detail

Repository
rABC Bitcoin ABC
Branch
deprecate-encrypted-msgs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25234
Build 50056: Build Diffcashtab-tests
Build 50055: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Oct 3 2023, 06:50
Fabien added a subscriber: Fabien.

Chronik does not yet support its full feature set

What features are missing ?

This should go through a deprecation cycle, see D14577.

This revision now requires changes to proceed.Oct 3 2023, 06:50

Chronik does not yet support its full feature set

What features are missing ?

Needs an API that returns an array of addresses that holds SLP UTXOs matching a given token ID. Further nice to have would be total balances associated with that token ID for each address but we can do that in-app if need be.

Will rehabilitate this feature with chronik improvements

quick note - if you end up going through with this you'll need to remove this button from SendToken.js as well

image.png (129×448 px, 11 KB)

Rebase to latest master, remove deprecation notice

forgot this was a stacked diff and pushed changes to the wrong place

We're not going to deprecate this, will be added to chronik