Differential D14581

[avalanche] Move the processor updatedBlockTip logic to a private method
ClosedPublic
Actions

Authored by Fabien on Oct 3 2023, 10:17.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCe35ec229a99d: [avalanche] Move the processor updatedBlockTip logic to a private method

Summary

This makes it possible to test the handler from unit tests, without having to setup a full validation interface.

There is no change in behavior.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_processor_updated_block_tip_private

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25240
Build 50066: Build Diff	lint-circular-dependencies · build-clang-tidy · build-diff · build-clang · build-without-wallet · build-debug
Build 50065: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 3 2023, 10:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 3 2023, 10:17

Fabien requested review of this revision.Oct 3 2023, 10:17

Fabien added a child revision: D14582: [avalanche] Fix the local proof status when it is already registered.

Harbormaster completed remote builds in B25240: Diff 42502.Oct 3 2023, 10:34

PiRK accepted this revision.Oct 3 2023, 10:36

This revision is now accepted and ready to land.Oct 3 2023, 10:36

Closed by commit rABCe35ec229a99d: [avalanche] Move the processor updatedBlockTip logic to a private method (authored by Fabien). · Explain WhyOct 3 2023, 10:58

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe35ec229a99d: [avalanche] Move the processor updatedBlockTip logic to a private method.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.h

1 line

processor.cpp

55 lines

Diff 42502

View Options

src/avalanche/processor.h