Page MenuHomePhabricator
Differential D14584

test: call VerifyLoadedChainstate during ChainTestingSetup
ClosedPublic
Actions

Authored by PiRK on Oct 3 2023, 13:19.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC71742ac7d667: test: call VerifyLoadedChainstate during ChainTestingSetup
Summary

for additional coverage and similarity to actual init process.

This is a backport of core#23736

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 3 2023, 13:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 3 2023, 13:19
PiRK requested review of this revision.Oct 3 2023, 13:19
teamcity edited the summary of this revision. (Show Details)Oct 3 2023, 13:19
PiRK added a child revision: D14585: refactor: Post-"Chainstate loading sequence coalescence" fixups.Oct 3 2023, 13:34
Harbormaster completed remote builds in B25243: Diff 42507.Oct 3 2023, 13:35
bytesofman added a subscriber: bytesofman.Oct 3 2023, 22:47
bytesofman added inline comments.
src/test/util/setup_common.cpp
244 ↗(On Diff #42507)

the core PR calls chainparams.GetConsensus(), instead of GetConfig() -- why the discrepancy?

PiRK added inline comments.Oct 4 2023, 06:35
src/test/util/setup_common.cpp
244 ↗(On Diff #42507)

This is one of the early changes in Bitcoin ABC vs Bitcoin Core, we wrap the chain params (among other things) in a Config object. This object has a GetChainParams() function to access the chain params, which the VerifyLoadedChainstate uses.

See D29

PiRK added inline comments.Oct 4 2023, 06:37
src/test/util/setup_common.cpp
244 ↗(On Diff #42507)

and D139

Fabien accepted this revision.Oct 4 2023, 08:57
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/test/util/setup_common.cpp
248 ↗(On Diff #42507)

This is the worst use of std::optional I've ever seen

This revision is now accepted and ready to land.Oct 4 2023, 08:57
Closed by commit rABC71742ac7d667: test: call VerifyLoadedChainstate during ChainTestingSetup (authored by James O'Beirne <james.obeirne@pm.me>, committed by PiRK). · Explain WhyOct 4 2023, 10:35
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC71742ac7d667: test: call VerifyLoadedChainstate during ChainTestingSetup.

Revision Contents
Changeset List

PathSize
src/
test/
util/
8 lines

Diff 42532

View Options

src/test/util/setup_common.cpp

Loading...