Paths

Table of Contentst

Differential D14596

Do not pass time getter to Chainstate helpers
ClosedPublic
Actions

Authored by PiRK on Oct 4 2023, 16:14.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC359af0d99d01: Do not pass time getter to Chainstate helpers

Summary

This is a partial backport of core#25168
https://github.com/bitcoin/bitcoin/pull/25168/commits/fa4ee53dca5ccf1b87f019f372ffc10528add943

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25265
Build 50116: Build Diff	build-debug · lint-circular-dependencies · build-without-wallet · build-diff · build-clang · build-clang-tidy
Build 50115: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 4 2023, 16:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 4 2023, 16:14

PiRK requested review of this revision.Oct 4 2023, 16:14

teamcity edited the summary of this revision. (Show Details)Oct 4 2023, 16:14

PiRK added a child revision: D14597: Do not pass Consensus::Params& to Chainstate helpers.Oct 4 2023, 16:15

Harbormaster completed remote builds in B25265: Diff 42541.Oct 4 2023, 16:34

Fabien accepted this revision.Oct 4 2023, 18:14

This revision is now accepted and ready to land.Oct 4 2023, 18:14

Closed by commit rABC359af0d99d01: Do not pass time getter to Chainstate helpers (authored by MacroFake <falke.marco@gmail.com>, committed by PiRK). · Explain WhyOct 5 2023, 03:34

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC359af0d99d01: Do not pass time getter to Chainstate helpers.

Revision Contents
Changeset List

Path

Size

src/

init.cpp

4 lines

node/

chainstate.h

3 lines

chainstate.cpp

6 lines

test/

util/

setup_common.cpp

3 lines

Diff 42541

View Options

src/init.cpp

View Options

src/node/chainstate.h

View Options

src/node/chainstate.cpp

View Options

src/test/util/setup_common.cpp

Do not pass time getter to Chainstate helpersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42541

src/init.cpp

src/node/chainstate.h

src/node/chainstate.cpp

src/test/util/setup_common.cpp

Do not pass time getter to Chainstate helpers
ClosedPublic
Actions

Revision Contents
Changeset List