Page MenuHomePhabricator
Differential D14604

[avalanche] Make the staking rewards activation chain dependent
ClosedPublic
Actions

Authored by Fabien on Oct 5 2023, 11:24.

Details

Reviewers
PiRK
bytesofman
Group Reviewers
Restricted Project
Commits
rABC13e2acb65859: [avalanche] Make the staking rewards activation chain dependent
Summary

This makes it possible to default enable staking rewards on mainnet only. The feature is not useful on test chains and can always be enabled manually.

Depends on D14517.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
disable_staking_rewards_on_test_chains_by_default
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25281
Build 50148: Build Diffbuild-without-wallet · build-clang · build-debug · lint-circular-dependencies · build-clang-tidy · build-diff
Build 50147: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 5 2023, 11:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2023, 11:24
Fabien requested review of this revision.Oct 5 2023, 11:24
Fabien changed the visibility from "Public (No Login Required)" to "Restricted Project (Project)".Oct 5 2023, 11:24
Harbormaster completed remote builds in B25281: Diff 42568.Oct 5 2023, 11:38
PiRK accepted this revision.Oct 5 2023, 12:00
This revision is now accepted and ready to land.Oct 5 2023, 12:00
bytesofman accepted this revision.Oct 5 2023, 16:39
Fabien changed the visibility from "Restricted Project (Project)" to "Public (No Login Required)".Oct 9 2023, 20:27
Closed by commit rABC13e2acb65859: [avalanche] Make the staking rewards activation chain dependent (authored by Fabien). · Explain WhyOct 9 2023, 20:27
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC13e2acb65859: [avalanche] Make the staking rewards activation chain dependent.

Revision Contents
Changeset List

PathSize
src/
avalanche/
5 lines
11 lines
consensus/
3 lines
node/
2 lines
policy/
block/
2 lines
rpc/
2 lines
test/
functional/
1 line
1 line

Diff 42568

View Options

src/avalanche/avalanche.h

Loading...
View Options

src/chainparams.cpp

Loading...
View Options

src/consensus/params.h

Loading...
View Options

src/node/miner.cpp

Loading...
View Options

src/policy/block/stakingrewards.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

test/functional/abc_mining_stakingrewards.py

Loading...
View Options

test/functional/abc_p2p_avalanche_policy_stakingrewards.py

Loading...