Page MenuHomePhabricator

[website] Don't switch the upgrade banner status on the upgrade timestamp
ClosedPublic

Authored by Fabien on Oct 10 2023, 19:45.

Details

Summary

The upgrade usually happens 1h after the timestamp due to being MTP based. Turning the banner to the upgraded status too early is confusing, so let's give some margin instead. 3h is chosen as it gives enough time for a dev to change the value manually after the upgrade completed (or delay it if needed), and worst case it's just late by 2h.

Depends on D14621.

Test Plan
bundle exec jekyll serve --incremental

Check the upgrade notice is still displayed.
Manually change the switchTime to see it in effect.

Diff Detail

Repository
rABCWEB Bitcoin ABC Website
Branch
switch_time_upgrade
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 25318
Build 50217: arc lint + arc unit