Use BlockStatus's modifier function to update status's value.
ClosedPublic
Actions

Authored by deadalnix on May 27 2018, 22:17.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGe11c605c1d85: Use BlockStatus's modifier function to update status's value.
rABCe11c605c1d85: Use BlockStatus's modifier function to update status's value.

Summary

As per title. Most of the code doesn't need to know about the internal layour of the status's field.

Depends on D1461

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

moarblockstatus

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2661
Build 3435: Bitcoin ABC Buildbot (legacy)
Build 3434: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 27 2018, 22:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 27 2018, 22:17

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D1463: Get rid of BlockStatusEnum.May 27 2018, 22:19

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2661: Diff 4003.May 27 2018, 22:54

schancel accepted this revision.May 28 2018, 18:05

This revision is now accepted and ready to land.May 28 2018, 18:05

Closed by commit rABCe11c605c1d85: Use BlockStatus's modifier function to update status's value. (authored by deadalnix). · Explain WhyMay 29 2018, 09:47

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

chain.h

12 lines

validation.cpp

18 lines

Diff 4003

View Options

src/chain.h