T3316
The 'too many unconfirmed ancestors' node error is no longer applicable in handleAliasRegistrationError, hence removing the error translation logic.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC38455aff4a7f: [Cashtab][Alias] Remove redundant node error translation in…
Attempt to register a new alias on a wallet with insifficient funds and ensure the node error is rendered as a UI pop up
grep -r handleAliasRegistrationError src/
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- handleAliasRegistrationError
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 25348 Build 50277: Build Diff cashtab-tests Build 50276: arc lint + arc unit
Event Timeline
Comment Actions
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Comment Actions
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Comment Actions
This is in that same category a few months ago where internal functions (e.g. registerAlias in this case) in a React component (a rendering class) can't be accessed directly. You can only test the initial state and props upon initialization but cases where we need to trigger a custom event (server outage) and then verify its reaction to that event is a challenge with how unit tests are currently set up in Cashtab.
This is mitigated by:
- manual test above to observe the error message pop up in the frontend
- grep -r handleAliasRegistrationError src/ to ensure no dependency on this removed function from anywhere else in Cashtab