Page MenuHomePhabricator
Differential D14652

move-only: test: make snapshot chainstate setup reusable
ClosedPublic
Actions

Authored by PiRK on Oct 19 2023, 14:10.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC88394e92b4d6: move-only: test: make snapshot chainstate setup reusable
Summary

For use in next commit.

Most easily reviewed with
--color-moved=dimmed_zebra --color-moved-ws=allow-indentation-change.

This is a partial backport of core#25667
https://github.com/bitcoin/bitcoin/pull/25667/commits/3a29dfbfb2c16a50d854f6f81428a68aa9180509

Depends on D14651

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 19 2023, 14:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 19 2023, 14:10
PiRK requested review of this revision.Oct 19 2023, 14:10
teamcity edited the summary of this revision. (Show Details)Oct 19 2023, 14:10
PiRK added a child revision: D14653: test: add reset_chainstate parameter for snapshot unittests.Oct 19 2023, 14:11
Harbormaster completed remote builds in B25375: Diff 42710.Oct 19 2023, 14:31
Fabien accepted this revision.Oct 23 2023, 12:37
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/test/validation_chainstatemanager_tests.cpp
285 ↗(On Diff #42710)

Good catch

This revision is now accepted and ready to land.Oct 23 2023, 12:37
Closed by commit rABC88394e92b4d6: move-only: test: make snapshot chainstate setup reusable (authored by James O'Beirne <james.obeirne@pm.me>, committed by PiRK). · Explain WhyOct 26 2023, 11:32
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC88394e92b4d6: move-only: test: make snapshot chainstate setup reusable.

Revision Contents
Changeset List

PathSize
src/
test/
312 lines

Diff 42801

View Options

src/test/validation_chainstatemanager_tests.cpp

Loading...