[avalanche] Use the remote proof status to confirm the presence/absence of a proof
ClosedPublic
Actions

Authored by Fabien on Oct 20 2023, 20:32.

Details

Reviewers

PiRK
bytesofman

Group Reviewers

Restricted Project

Commits

rABCd6da183ea362: [avalanche] Use the remote proof status to confirm the presence/absence of a…

Summary

This prevents a node from being out of sync from the network if it is missing the connection with a node.

Depends on D14664.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 20 2023, 20:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 20 2023, 20:32

Fabien requested review of this revision.Oct 20 2023, 20:32

Harbormaster completed remote builds in B25391: Diff 42726.Oct 20 2023, 21:05

PiRK requested changes to this revision.Oct 22 2023, 12:13

PiRK added a subscriber: PiRK.

PiRK added inline comments.

src/avalanche/test/peermanager_tests.cpp
2719 ↗	(On Diff #42726)
2737 ↗	(On Diff #42726)	wrong comment (accidentaly duplicated from line 2705)

This revision now requires changes to proceed.Oct 22 2023, 12:13

Fix comments

Harbormaster completed remote builds in B25393: Diff 42728.Oct 22 2023, 15:59

PiRK accepted this revision.Oct 22 2023, 18:13

This revision is now accepted and ready to land.Oct 22 2023, 18:13

bytesofman accepted this revision.Oct 23 2023, 18:31

Fabien added a child revision: D14670: [avalanche] Reconcile the proofs pulled back from dangling.Oct 24 2023, 08:12

Closed by commit rABCd6da183ea362: [avalanche] Use the remote proof status to confirm the presence/absence of a… (authored by Fabien). · Explain WhyOct 25 2023, 10:20

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCd6da183ea362: [avalanche] Use the remote proof status to confirm the presence/absence of a….

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.cpp

21 lines

test/

peermanager_tests.cpp

104 lines

Diff 42779

View Options

src/avalanche/peermanager.cpp