Page MenuHomePhabricator
Differential D14672

coinstats: Extract in-members to in-params, return purely out-param CCoinsStats
ClosedPublic
Actions

Authored by PiRK on Oct 24 2023, 08:44.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7f9ab27e8cc9: coinstats: Extract in-members to in-params, return purely out-param CCoinsStats
Summary

Currently, CCoinsStats is a struct with both in-params and out-params
where the hash_type and index_requested members are the only in-params.

Move the in-params out of the struct, so as to make CCoinsStats a pure out-param struct.

Modify GetUTXOStats to return an optional CCoinsStats instead of a status bool. Callers are modified accordingly.

In rpc/blockchain.cpp, we discover that GetUTXOStats' status bool when
getting UTXO stats for pprev was not checked for error. We fix this as
well.

This is a partial backport of core#24410
https://github.com/bitcoin/bitcoin/pull/24410/commits/a789f3f2b878e1236f8e043a8bb1ffb1afc1b673
https://github.com/bitcoin/bitcoin/pull/24410/commits/46eb9fc56a296a2acea10ec7e5bf7b1827f73c45
https://github.com/bitcoin/bitcoin/pull/24410/commits/524463daf6a10b20a4e20116a68101a684929eda

Depends on D14671

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
node/
22 lines
64 lines
rpc/
45 lines
test/
4 lines
11 lines

Diff 42809

View Options

src/node/coinstats.h

Loading...
View Options

src/node/coinstats.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/test/coinstatsindex_tests.cpp

Loading...
View Options

src/validation.cpp

Loading...