Differential D14680

[avalanche] Don't send peers with no node attached in compact proofs
ClosedPublic
Actions

Authored by Fabien on Oct 24 2023, 16:18.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC2cb9af01eb66: [avalanche] Don't send peers with no node attached in compact proofs

Summary

This doesn't prevent relaying as inventory but it ensures a smooth cleanup of the dangling proofs after the remote proofs are in use. As a consequence we compare the compact proofs with the peer set to determine what is missing from our remote.

Depends on D14679.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

share_connected_proofs

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25418
Build 50417: Build Diff	build-clang-tidy · build-clang · build-debug · build-diff · build-without-wallet · lint-circular-dependencies
Build 50416: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 24 2023, 16:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 24 2023, 16:18

Fabien requested review of this revision.Oct 24 2023, 16:18

Harbormaster completed remote builds in B25418: Diff 42758.Oct 24 2023, 16:32

PiRK accepted this revision.Oct 24 2023, 16:47

This revision is now accepted and ready to land.Oct 24 2023, 16:47

Closed by commit rABC2cb9af01eb66: [avalanche] Don't send peers with no node attached in compact proofs (authored by Fabien). · Explain WhyOct 25 2023, 10:21

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC2cb9af01eb66: [avalanche] Don't send peers with no node attached in compact proofs.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.cpp

35 lines

net_processing.cpp

46 lines

test/

functional/

abc_p2p_avalanche_remote_proofs.py

89 lines

abc_p2p_compactproofs.py

58 lines

Diff 42758

src/avalanche/peermanager.cpp

Loading...

src/net_processing.cpp

Loading...

test/functional/abc_p2p_avalanche_remote_proofs.py

Loading...

test/functional/abc_p2p_compactproofs.py

Loading...