validation: add CChainState::m_disabled and ChainMan::isUsable
ClosedPublic
Actions

Authored by PiRK on Oct 25 2023, 06:17.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCb9af6d5b906c: validation: add CChainState::m_disabled and ChainMan::isUsable

Summary

and remove m_snapshot_validated. This state can now be inferred by the
number of isUsable chainstates.

m_disabled is used to signal that a chainstate should no longer be used
by validation logic; it is used as a sentinel when background validation
completes or if the snapshot chainstate is found to be invalid.

isUsable is a convenience method that incorporates m_disabled.

This is a partial backport of core#25740
https://github.com/bitcoin/bitcoin/pull/25740/commits/c29f26b47b8ef978d8689dc0222aa663361ee6cb

Depends on D14673

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25435
Build 50451: Build Diff	lint-circular-dependencies · build-without-wallet · build-clang-tidy · build-diff · build-debug · build-clang
Build 50450: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 25 2023, 06:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 25 2023, 06:17

PiRK requested review of this revision.Oct 25 2023, 06:17

teamcity edited the summary of this revision. (Show Details)Oct 25 2023, 06:18

PiRK added a child revision: D14686: move-only-ish: init: factor out chainstate initialization.Oct 25 2023, 06:21

Harbormaster completed remote builds in B25428: Diff 42768.Oct 25 2023, 06:35

Fabien requested changes to this revision.Oct 25 2023, 09:38

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/validation.cpp
5773 ↗	(On Diff #42768)	dito
src/validation.h
1146 ↗	(On Diff #42768)	Can we rename the param to pchainstate or something similar ? cs usually stands for critical section, hence cs_main so this is confusing as it sounds like a mutex