Page MenuHomePhabricator

[e.cash] Remove mention of bits for the denomination
ClosedPublic

Authored by Mengerian on Oct 26 2023, 19:33.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC7ea1e609a913: [e.cash] Remove mention of bits for the denomination
Summary

The term "bits" is not widely used in the eCash community.

Test Plan

Read the pages to make sure they read well
git grep bits

Diff Detail

Repository
rABC Bitcoin ABC
Branch
bits
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25449
Build 50479: Build Diff
Build 50478: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Oct 26 2023, 21:27

This was the last diff for which the windows crossbuild succeeded, so I'm running it to check if it still works at this commit, or if the failure is not related to a change in code (change in CI hardware?)

Tail of the build log:

  \-PE	    7fd4e49d0000-    7fd4e49e9000	\               shcore
ELF	    7fd4e49e9000-    7fd4e4a00000	Deferred        version<elf>
  \-PE	    7fd4e49f0000-    7fd4e4a00000	\               version
ELF	    7fd4e4a00000-    7fd4e4bb9000	Deferred        gdi32<elf>
  \-PE	    7fd4e4a20000-    7fd4e4bb9000	\               gdi32
ELF	    7fd4e4bb9000-    7fd4e4e51000	Deferred        user32<elf>
  \-PE	    7fd4e4be0000-    7fd4e4e51000	\               user32
ELF	    7fd4e4e51000-    7fd4e4eb5000	Deferred        shlwapi<elf>
  \-PE	    7fd4e4e60000-    7fd4e4eb5000	\               shlwapi
ELF	    7fd4e4eb5000-    7fd4e58ee000	Deferred        shell32<elf>
  \-PE	    7fd4e4ed0000-    7fd4e58ee000	\               shell32
ELF	    7fd4e58ee000-    7fd4e59e0000	Deferred        msvcrt<elf>
  \-PE	    7fd4e5910000-    7fd4e59e0000	\               msvcrt
ELF	    7fd4e59e0000-    7fd4e5a14000	Deferred        iphlpapi<elf>
  \-PE	    7fd4e59f0000-    7fd4e5a14000	\               iphlpapi
ELF	    7fd4e5a14000-    7fd4e5a3c000	Deferred        bcrypt<elf>
  \-PE	    7fd4e5a20000-    7fd4e5a3c000	\               bcrypt
ELF	    7fd4e5b3c000-    7fd4e5bd8000	Deferred        advapi32<elf>
  \-PE	    7fd4e5b50000-    7fd4e5bd8000	\               advapi32
ELF	    7fd4e5bd8000-    7fd4e5bec000	Deferred        libnss_files.so.2
ELF	    7fd4e5e56000-    7fd4e5e7e000	Deferred        liblzma.so.5
ELF	    7fd4e5e7e000-    7fd4e5e98000	Deferred        libgcc_s.so.1
ELF	    7fd4e5e98000-    7fd4e5fdc000	Deferred        libm.so.6
ELF	    7fd4e5fdc000-    7fd4e5ff7000	Deferred        libunwind.so.8
ELF	    7fd4e5ff9000-    7fd4e5fff000	Deferred        libdl.so.2
ELF	    7fd4e5fff000-    7fd4e61d3000	Deferred        libc.so.6
ELF	    7fd4e61d3000-    7fd4e61f5000	Deferred        libpthread.so.0
ELF	    7fd4e61f7000-    7fd4e6203000	Deferred        libffi.so.7
ELF	    7fd4e63af000-    7fd4e63dc000	Deferred        ld-linux-x86-64.so.2
Threads:
process  tid      prio (all id:s are in hex)
0000000c services.exe
	0000000d    0
	0000000e    0
	00000020    0
	0000002e    0
00000011 explorer.exe
	00000012    0
0000001e winedevice.exe
	0000001f    0
	00000021    0
	00000022    0
0000002c winedevice.exe
	0000002d    0
	0000002f    0
	00000030    0
	00000031    0
	00000032    0
00000033 (D) Z:\results\artifacts\bin\test_bitcoin.exe
	00000034    0 <==
	00000058    0
	0000001d    0
	0000001c    0
System information:
    Wine build: wine-5.0.3 (Debian 5.0.3-3)
    Platform: x86_64
    Version: Windows 7
    Host system: Linux
    Host version: 4.19.0-10-amd64
Build build-win64 failed with exit code 5

Tail of the build log:

ELF	    7f1cdc196000-    7f1cdc1ad000	Deferred        version<elf>
  \-PE	    7f1cdc1a0000-    7f1cdc1ad000	\               version
ELF	    7f1cdc1ad000-    7f1cdc366000	Deferred        gdi32<elf>
  \-PE	    7f1cdc1c0000-    7f1cdc366000	\               gdi32
ELF	    7f1cdc366000-    7f1cdc5fe000	Deferred        user32<elf>
  \-PE	    7f1cdc390000-    7f1cdc5fe000	\               user32
ELF	    7f1cdc5fe000-    7f1cdc662000	Deferred        shlwapi<elf>
  \-PE	    7f1cdc610000-    7f1cdc662000	\               shlwapi
ELF	    7f1cdc662000-    7f1cdd09b000	Deferred        shell32<elf>
  \-PE	    7f1cdc680000-    7f1cdd09b000	\               shell32
ELF	    7f1cdd09b000-    7f1cdd18d000	Deferred        msvcrt<elf>
  \-PE	    7f1cdd0c0000-    7f1cdd18d000	\               msvcrt
ELF	    7f1cdd18d000-    7f1cdd1c1000	Deferred        iphlpapi<elf>
  \-PE	    7f1cdd1a0000-    7f1cdd1c1000	\               iphlpapi
ELF	    7f1cdd1c1000-    7f1cdd1e9000	Deferred        bcrypt<elf>
  \-PE	    7f1cdd1d0000-    7f1cdd1e9000	\               bcrypt
ELF	    7f1cdd2e9000-    7f1cdd385000	Deferred        advapi32<elf>
  \-PE	    7f1cdd300000-    7f1cdd385000	\               advapi32
ELF	    7f1cdd385000-    7f1cdd399000	Deferred        libnss_files.so.2
ELF	    7f1cdd603000-    7f1cdd62b000	Deferred        liblzma.so.5
ELF	    7f1cdd62b000-    7f1cdd645000	Deferred        libgcc_s.so.1
ELF	    7f1cdd645000-    7f1cdd789000	Deferred        libm.so.6
ELF	    7f1cdd789000-    7f1cdd7a4000	Deferred        libunwind.so.8
ELF	    7f1cdd7a6000-    7f1cdd7ac000	Deferred        libdl.so.2
ELF	    7f1cdd7ac000-    7f1cdd980000	Deferred        libc.so.6
ELF	    7f1cdd980000-    7f1cdd9a2000	Deferred        libpthread.so.0
ELF	    7f1cdd9a4000-    7f1cdd9b0000	Deferred        libffi.so.7
ELF	    7f1cddb5c000-    7f1cddb89000	Deferred        ld-linux-x86-64.so.2
Threads:
process  tid      prio (all id:s are in hex)
0000000c services.exe
	0000000d    0
	0000000e    0
	00000020    0
	00000023    0
	0000002f    0
00000013 explorer.exe
	00000014    0
0000001e winedevice.exe
	0000001f    0
	00000021    0
	00000022    0
0000002d winedevice.exe
	0000002e    0
	00000030    0
	00000031    0
	00000032    0
	00000033    0
00000034 (D) Z:\results\artifacts\bin\test_bitcoin.exe
	00000035    0 <==
	0000001d    0
	0000001c    0
	0000005a    0
System information:
    Wine build: wine-5.0.3 (Debian 5.0.3-3)
    Platform: x86_64
    Version: Windows 7
    Host system: Linux
    Host version: 4.19.0-10-amd64
Build build-win64 failed with exit code 5