Page MenuHomePhabricator
Differential D14721

[e.cash] Use constant for latest version on upgrade page
ClosedPublic
Actions

Authored by Mengerian on Nov 1 2023, 16:20.

Details

Reviewers
johnkuney
bytesofman
Group Reviewers
Restricted Project
Commits
rABC2d7735456310: [e.cash] Use constant for latest version on upgrade page
Summary

So we only have to change the version in one place next time.

Test Plan

Ran it locally, looks fine

Diff Detail

Repository
rABC Bitcoin ABC
Branch
e.cash-version-variable
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25508
Build 50597: Build Diff
Build 50596: arc lint + arc unit

Event Timeline

Mengerian created this revision.Nov 1 2023, 16:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 1 2023, 16:20
Mengerian requested review of this revision.Nov 1 2023, 16:20
Harbormaster completed remote builds in B25507: Diff 42899.Nov 1 2023, 16:20
johnkuney requested changes to this revision.Nov 1 2023, 16:31
johnkuney added inline comments.
web/e.cash/pages/upgrade.js
11 ↗(On Diff #42899)

camelCase for the variable

97 ↗(On Diff #42899)

missing space between 'version' and variable. May have to add a {' '}

This revision now requires changes to proceed.Nov 1 2023, 16:31
Mengerian updated this revision to Diff 42900.Nov 1 2023, 16:51

Use camel case
Add space

Harbormaster completed remote builds in B25508: Diff 42900.Nov 1 2023, 16:51
bytesofman added a subscriber: bytesofman.Nov 1 2023, 18:17

@bot preview-e.cash

teamcity awarded a token.Nov 1 2023, 18:17

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41659 for the next 60 minutes.

bytesofman accepted this revision.Nov 1 2023, 18:36
johnkuney accepted this revision.Nov 1 2023, 20:46
This revision is now accepted and ready to land.Nov 1 2023, 20:46
Closed by commit rABC2d7735456310: [e.cash] Use constant for latest version on upgrade page (authored by Mengerian). · Explain WhyNov 1 2023, 20:49
This revision was automatically updated to reflect the committed changes.
Mengerian added a commit: rABC2d7735456310: [e.cash] Use constant for latest version on upgrade page.

Revision Contents
Changeset List

PathSize
web/
e.cash/
pages/
22 lines

Diff 42900

View Options

web/e.cash/pages/upgrade.js

Loading...