Page MenuHomePhabricator
Differential D14722

[e.cash] Use camelCase for constant
ClosedPublic
Actions

Authored by Mengerian on Nov 1 2023, 20:52.

Details

Reviewers
johnkuney
bytesofman
Group Reviewers
Restricted Project
Commits
rABC882f7450604c: [e.cash] Use camelCase for constant
Test Plan

Ran it locally, looks fine

Diff Detail

Repository
rABC Bitcoin ABC
Branch
e.cash-mining-camelCase
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25509
Build 50599: Build Diff
Build 50598: arc lint + arc unit

Event Timeline

Mengerian created this revision.Nov 1 2023, 20:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 1 2023, 20:52
Mengerian requested review of this revision.Nov 1 2023, 20:52
Harbormaster completed remote builds in B25509: Diff 42907.Nov 1 2023, 20:52
bytesofman requested changes to this revision.Nov 1 2023, 22:15
bytesofman added a subscriber: bytesofman.
bytesofman added inline comments.
web/e.cash/pages/mining.js
12

might as well do the whole thing

181
This revision now requires changes to proceed.Nov 1 2023, 22:15
Mengerian added inline comments.Nov 1 2023, 23:52
web/e.cash/pages/mining.js
12

might as well do the whole thing

Yeah, I was thinking about that, but wasn't sure since getblocktemplate is an RPC command that's all lower-case

bytesofman accepted this revision.Nov 2 2023, 19:02
bytesofman added inline comments.
web/e.cash/pages/mining.js
12

lol. subjective either way then. in general tho, JS standard would be to camelcase everything, even stuff that is not camel cased outside of JS.

so -- your call, feel free to land it either way.

This revision is now accepted and ready to land.Nov 2 2023, 19:02
Closed by commit rABC882f7450604c: [e.cash] Use camelCase for constant (authored by Mengerian). · Explain WhyNov 3 2023, 17:36
This revision was automatically updated to reflect the committed changes.
Mengerian added a commit: rABC882f7450604c: [e.cash] Use camelCase for constant.

Revision Contents
Changeset List

PathSize
web/
e.cash/
pages/
4 lines

Diff 42907

View Options

web/e.cash/pages/mining.js

Loading...