[e.cash] Use camelCase for constant
ClosedPublic
Actions

Authored by Mengerian on Nov 1 2023, 20:52.

Details

Reviewers

johnkuney
bytesofman

Group Reviewers

Restricted Project

Commits

rABC882f7450604c: [e.cash] Use camelCase for constant

Test Plan

Ran it locally, looks fine

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Mengerian requested review of this revision.Nov 1 2023, 20:52

bytesofman requested changes to this revision.Nov 1 2023, 22:15

bytesofman added a subscriber: bytesofman.

bytesofman added inline comments.

web/e.cash/pages/mining.js
12 ↗	(On Diff #42907)	might as well do the whole thing
181 ↗	(On Diff #42907)

This revision now requires changes to proceed.Nov 1 2023, 22:15

web/e.cash/pages/mining.js
12 ↗	(On Diff #42907)	might as well do the whole thing Yeah, I was thinking about that, but wasn't sure since `getblocktemplate` is an RPC command that's all lower-case

bytesofman added inline comments.

web/e.cash/pages/mining.js
12 ↗	(On Diff #42907)	lol. subjective either way then. in general tho, JS standard would be to camelcase everything, even stuff that is not camel cased outside of JS. so -- your call, feel free to land it either way.