Updated processChronikWsMsg() to refresh pricing every 90 blocks rather than every block

When you run this diff for the first time it will refresh anyway even if the pricing height is not divisible by 90, because the aliasPricing state var starts off as null on app load and needs to be populated. After this, it will pick up a new block and then skip the refresh if the height is not divisible by 90.

If the prices array length between the server and cashtab matches then it will also skip the refresh as it would indicate no new pricing tiers have been published.

Unit tests for processChronikWsMsg() updated for the following permutations:

1. Alias prices refreshed with default null aliasPricing and prices height divisible by 90
2. Alias prices refreshed with default null aliasPricing and prices height not divisible by 90
3. Alias prices refreshed with existing aliasPricing and prices height divisible by 90
4. Alias prices NOT refreshed with existing aliasPricing and prices height not divisible by 90
5. Alias prices NOT refreshed with existing aliasPricing and prices height divisible by 90 and prices array length unchanged
6. Alias prices NOT refreshed with existing aliasPricing and prices height not divisible by 90 and prices array length unchanged

I must have missed something here

ok, you didn't miss anything, the above approach doesn't work. Any block height related optimization will incur an API call to get the latest blockheight as a minimum.

Discussed alternate approaches with Joey, including a direct cross-monorepo reference to the alias prices config in alias-server repo directly, similar to how some apps in the monorepo are directly importing the mock-chronik-client module via relative path.

However React has a very strict restriction on importing modules from outside of its /src/ path.
There are two ways of getting around it:

1. Disable certain elements of webpack config (not recommended as we would lose other protections)
2. Symlink (not recommended, as it's for importing entire npm packages and we don't want to import the whole alias-server into Cashtab)
3. Simply duplicating the prices constant in Cashtab config (not recommended for obvious reasons)

In addition, for approaches 1 & 2 above to work we would need to somehow modify Cashtab's teamcity trigger to build and deploy if alias-server alias constants change, which all up is a significant chunk of engineering for a low ROI impact.

Long story short, we concluded your original suggestion of polling prices on each new block is the way to go and updated diff accordingly.

The unit test permutations are now:

• processChronikWsMsg() refreshes alias prices when aliasPrices is null
• processChronikWsMsg() refreshes alias prices when aliasPrices exists, server and cashtab prices array length do not match
• processChronikWsMsg() DOES NOT refresh alias prices when aliasPrices exists, server and cashtab prices array length do match

Console log samples:

• When new block found and aliasPrices in Cashtab is yet to be populated

• When new block found and aliasPrices in Cashtab matches the latest response from alias-server

Alias.js now pulls aliasPrices as a context variable and triggers a regresh if none exist.

Added real time localized pricing displays per alias input, improved not null checks, added default value for aliasPAram in queryAliasServer args.
LocalString formatting applied to pricing since it's likely to eventually be a large number in prod.

Removed aliasFee state far and updated component to access directly from the aliasPrices object

Removed debug logs

Per tg chat, disabling alias registration if the pricing array from API has more than one entry. I've kept the Alias component itself still accessible as the user should still be able to check their purchased aliases, which is separate from pricing matters.

Updated array length checks, error message and price element index.

Updated for pricing array length 0 check, diff summary and test plan.

In D14728#333005, @Fabien wrote:

wait for a new block to be found and observe the "New block found, refreshing alias prices" message in console

I think this message has been removed ?

It has but this is why it says "Temporarily reintate previous debug log statements..." beforehand because it is still a material change in this diff and should remain as a test, albeit requiring a manual log insertion to verify.