Paths

Table of Contentst

Differential D14747

[net processing] Remove fClient and m_limited_node
ClosedPublic
Actions

Authored by PiRK on Nov 7 2023, 12:14.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC6a62c795ad47: [net processing] Remove fClient and m_limited_node

Summary

[net processing] Remove fClient and m_limited_node

fClient is replaced by CanServeBlocks(), and m_limited_node is replaced
by IsLimitedPeer().

https://github.com/bitcoin/bitcoin/pull/25514/commits/f65e83d51bfb6a34f1d5efccfb3d8786a51a4534

[net processing] Inline and simplify UpdatePreferredDownload

We inline UpdatePreferredDownload because it is only used in one
location during the version handshake. We simplify it by removing the
initial subtraction of state->fPreferredDownload from
nPreferredDownload. This is ok since the version handshake is only
called once per peer and state->fPreferredDownload will always be
false before the newly inlined code is called, making the subtraction a
noop.

https://github.com/bitcoin/bitcoin/pull/24543/commits/a4c55a93ef9277e1043c286120e2417652ee8bbb

This is a partial backport of core#25514 and core#24543

Depends on D14746

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 7 2023, 12:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 7 2023, 12:14

PiRK requested review of this revision.Nov 7 2023, 12:14

teamcity edited the summary of this revision. (Show Details)Nov 7 2023, 12:14

comment style

PiRK added a child revision: D14748: [net processing] Remove CNode::nServices.Nov 7 2023, 12:24

Harbormaster completed remote builds in B25549: Diff 42973.Nov 7 2023, 12:32

Harbormaster completed remote builds in B25550: Diff 42974.Nov 7 2023, 12:38

Fabien accepted this revision.Nov 8 2023, 09:26

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/net_processing.cpp
3802 ↗	(On Diff #42974)	Nice to see this confusing flag gone, the name was horrible

This revision is now accepted and ready to land.Nov 8 2023, 09:26

rebase

Harbormaster completed remote builds in B25564: Diff 42990.Nov 8 2023, 10:49

Closed by commit rABC6a62c795ad47: [net processing] Remove fClient and m_limited_node (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyNov 8 2023, 15:10

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC6a62c795ad47: [net processing] Remove fClient and m_limited_node.

PiRK mentioned this in D14863: [net processing] Move nPreferredDownload into PeerManagerImpl.Nov 28 2023, 14:03

PiRK mentioned this in rABC95fee839874a: [net processing] Move nPreferredDownload into PeerManagerImpl.Nov 29 2023, 11:38

Revision Contents
Changeset List

Path

Size

src/

4 lines

net_processing.cpp

48 lines

Diff 43002

src/net.h

Loading...

src/net_processing.cpp

Loading...