Page MenuHomePhabricator
Differential D14750

[net processing] Remove CNode::nLocalServices
ClosedPublic
Actions

Authored by PiRK on Nov 7 2023, 12:44.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC81be7b59d93e: [net processing] Remove CNode::nLocalServices
Summary

This concludes backport of core#25514
https://github.com/bitcoin/bitcoin/pull/25514/commits/8d8eeb422e64ccd08bce92eed2ee9cbbf55ffd67

Depends on D14749

Test Plan

ninja all check-all bitcoin-fuzzers

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 7 2023, 12:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 7 2023, 12:44
PiRK requested review of this revision.Nov 7 2023, 12:44
teamcity edited the summary of this revision. (Show Details)Nov 7 2023, 12:44
PiRK updated this revision to Diff 42980.Nov 7 2023, 12:56

nits

PiRK added inline comments.Nov 7 2023, 12:58
src/test/net_tests.cpp
72–76 ↗(On Diff #42980)

The services flags turned out to not be needed in the test using this function, the connection type is enough.

Harbormaster completed remote builds in B25555: Diff 42979.Nov 7 2023, 13:05
Harbormaster completed remote builds in B25556: Diff 42980.Nov 7 2023, 13:13
Fabien requested changes to this revision.Nov 8 2023, 09:56
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/net_processing.cpp
1064 ↗(On Diff #42980)

Nope, keep that

This revision now requires changes to proceed.Nov 8 2023, 09:56
PiRK updated this revision to Diff 42993.Nov 8 2023, 10:22

restore doxygen comment and rebase

Harbormaster completed remote builds in B25567: Diff 42993.Nov 8 2023, 11:07
Fabien accepted this revision.Nov 8 2023, 11:46
This revision is now accepted and ready to land.Nov 8 2023, 11:46
Closed by commit rABC81be7b59d93e: [net processing] Remove CNode::nLocalServices (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyNov 8 2023, 15:11
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC81be7b59d93e: [net processing] Remove CNode::nLocalServices.
PiRK mentioned this in D15713: fuzz: Rework strong and weak net enum fuzzing.Mar 18 2024, 09:09
PiRK mentioned this in rABCbf123f046d93: fuzz: Rework strong and weak net enum fuzzing.Mar 18 2024, 12:31

Revision Contents
Changeset List

PathSize
src/
avalanche/
test/
4 lines
25 lines
28 lines
92 lines
test/
33 lines
fuzz/
3 lines
6 lines
4 lines
3 lines
34 lines
util/
2 lines
3 lines

Diff 43005

View Options

src/avalanche/test/processor_tests.cpp

Loading...
View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/test/denialofservice_tests.cpp

Loading...
View Options

src/test/fuzz/net.cpp

Loading...
View Options

src/test/fuzz/process_message.cpp

Loading...
View Options

src/test/fuzz/process_messages.cpp

Loading...
View Options

src/test/fuzz/util.h

Loading...
View Options

src/test/net_tests.cpp

Loading...
View Options

src/test/util/net.h

Loading...
View Options

src/test/util/net.cpp

Loading...