Page MenuHomePhabricator
Differential D14768

Replace MakeSpan helper with Span deduction guide
ClosedPublic
Actions

Authored by PiRK on Nov 10 2023, 14:42.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7d917f5c5c97: Replace MakeSpan helper with Span deduction guide
Summary

C++17 supports user-defined deduction guides, allowing class constructors to be invoked without specifying class template arguments. Instead, the code can contain rules to infer the template arguments from the constructor argument types.

This alleviates the need for the MakeSpan helper. Convert the existing MakeSpan rules into deduction rules for Span itself, and replace all invocations of MakeSpan with just Span ones.

This is a partial backport of core#23413
https://github.com/bitcoin/bitcoin/pull/23413/commits/568dd2f83900a11a4dbba1250722791a135bf0a9

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Nov 10 2023, 14:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 10 2023, 14:42
PiRK requested review of this revision.Nov 10 2023, 14:42
teamcity edited the summary of this revision. (Show Details)Nov 10 2023, 14:42
PiRK added a child revision: D14769: More Span simplifications.Nov 10 2023, 14:44
Harbormaster completed remote builds in B25589: Diff 43033.Nov 10 2023, 14:59
Fabien accepted this revision.Nov 10 2023, 15:30
This revision is now accepted and ready to land.Nov 10 2023, 15:30
Closed by commit rABC7d917f5c5c97: Replace MakeSpan helper with Span deduction guide (authored by Pieter Wuille <pieter@wuille.net>, committed by PiRK). · Explain WhyNov 13 2023, 07:05
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC7d917f5c5c97: Replace MakeSpan helper with Span deduction guide.
PiRK mentioned this in D14775: fix OSX build failure related to Span deduction guide in macro.Nov 13 2023, 08:02
PiRK mentioned this in rABC31adc3630ad3: fix OSX build failure related to Span deduction guide in macro.Nov 13 2023, 08:52
PiRK mentioned this in D15859: span: Add std::byte helpers.Apr 3 2024, 07:44
PiRK mentioned this in D17157: util: Add ParseHex<std::byte>() helper.Mon, Nov 18, 10:25
PiRK mentioned this in rABC000b0266e7e8: util: Add ParseHex<std::byte>() helper.Mon, Nov 18, 19:57

Revision Contents
Changeset List

PathSize
src/
2 lines
8 lines
4 lines
8 lines
2 lines
6 lines
script/
6 lines
2 lines
seeder/
2 lines
44 lines
test/
5 lines
138 lines
2 lines
wallet/
rpc/
2 lines
2 lines
2 lines

Diff 43033

View Options

src/base58.cpp

Loading...
View Options

src/compressor.h

Loading...
View Options

src/netaddress.h

Loading...
View Options

src/netaddress.cpp

Loading...
View Options

src/psbt.h

Loading...
View Options

src/pubkey.h

Loading...
View Options

src/script/descriptor.cpp

Loading...
View Options

src/script/sign.h

Loading...
View Options

src/seeder/bitcoin.cpp

Loading...
View Options

src/span.h

Loading...
View Options

src/test/crypto_tests.cpp

Loading...
View Options

src/test/net_tests.cpp

Loading...
View Options

src/test/sigcache_tests.cpp

Loading...
View Options

src/wallet/rpc/backup.cpp

Loading...
View Options

src/wallet/rpc/encrypt.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...