Page MenuHomePhabricator

Cleanup the Nov. 15 2023 activation code and prepare for the May 15 2024 upgrade
ClosedPublic

Authored by Fabien on Nov 23 2023, 14:42.

Details

Summary

Clean up the activation code by activating based on block height, remove the past activation tests, and prepare the test suite for the next activation.

Test Plan
ninja check-extended

Run IBD.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Nov 23 2023, 14:42

@bot build-ibd build-ibd-no-assumevalid-checkpoint

Failed tests logs:

====== Bitcoin ABC functional tests: abc_mining_stakingrewards.py ======

------- Stdout: -------
2023-11-23T14:48:28.661000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20231123_144629/abc_mining_stakingrewards_67
2023-11-23T14:48:30.840000Z TestFramework (INFO): Staking rewards not ready yet, check getblocktemplate lacks the staking rewards data
2023-11-23T14:48:30.842000Z TestFramework (INFO): Staking rewards not ready yet, check the miner doesn't produce the staking rewards output
2023-11-23T14:48:30.849000Z TestFramework (INFO): Staking rewards are computed, check the block template returns the staking rewards data
2023-11-23T14:48:33.210000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 142, in main
    self.run_test()
  File "/work/test/functional/abc_mining_stakingrewards.py", line 144, in run_test
    assert "stakingrewards" in gbt["coinbasetxn"]
AssertionError
2023-11-23T14:48:33.260000Z TestFramework (INFO): Stopping nodes
2023-11-23T14:48:33.512000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20231123_144629/abc_mining_stakingrewards_67
2023-11-23T14:48:33.512000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20231123_144629/abc_mining_stakingrewards_67/test_framework.log
2023-11-23T14:48:33.512000Z TestFramework (ERROR): 
2023-11-23T14:48:33.512000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20231123_144629/abc_mining_stakingrewards_67' to consolidate all logs
2023-11-23T14:48:33.512000Z TestFramework (ERROR): 
2023-11-23T14:48:33.512000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2023-11-23T14:48:33.512000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2023-11-23T14:48:33.512000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_mining_stakingrewards.py

Fabien planned changes to this revision.Nov 23 2023, 14:52

Failed tests logs:

====== Bitcoin ABC functional tests: abc_mining_stakingrewards.py ======

------- Stdout: -------
2023-11-23T14:51:31.565000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20231123_144632/abc_mining_stakingrewards_67
2023-11-23T14:51:34.261000Z TestFramework (INFO): Staking rewards not ready yet, check getblocktemplate lacks the staking rewards data
2023-11-23T14:51:34.263000Z TestFramework (INFO): Staking rewards not ready yet, check the miner doesn't produce the staking rewards output
2023-11-23T14:51:34.277000Z TestFramework (INFO): Staking rewards are computed, check the block template returns the staking rewards data
2023-11-23T14:51:36.603000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 142, in main
    self.run_test()
  File "/work/test/functional/abc_mining_stakingrewards.py", line 144, in run_test
    assert "stakingrewards" in gbt["coinbasetxn"]
AssertionError
2023-11-23T14:51:36.654000Z TestFramework (INFO): Stopping nodes
2023-11-23T14:51:37.006000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20231123_144632/abc_mining_stakingrewards_67
2023-11-23T14:51:37.006000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20231123_144632/abc_mining_stakingrewards_67/test_framework.log
2023-11-23T14:51:37.006000Z TestFramework (ERROR): 
2023-11-23T14:51:37.006000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20231123_144632/abc_mining_stakingrewards_67' to consolidate all logs
2023-11-23T14:51:37.006000Z TestFramework (ERROR): 
2023-11-23T14:51:37.006000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2023-11-23T14:51:37.006000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2023-11-23T14:51:37.006000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_mining_stakingrewards.py

Failed tests logs:

====== Bitcoin ABC functional tests: abc_mining_stakingrewards.py ======

------- Stdout: -------
2023-11-23T14:51:11.296000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20231123_144745/abc_mining_stakingrewards_67
2023-11-23T14:51:14.128000Z TestFramework (INFO): Staking rewards not ready yet, check getblocktemplate lacks the staking rewards data
2023-11-23T14:51:14.133000Z TestFramework (INFO): Staking rewards not ready yet, check the miner doesn't produce the staking rewards output
2023-11-23T14:51:14.171000Z TestFramework (INFO): Staking rewards are computed, check the block template returns the staking rewards data
2023-11-23T14:51:16.836000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 142, in main
    self.run_test()
  File "/work/test/functional/abc_mining_stakingrewards.py", line 144, in run_test
    assert "stakingrewards" in gbt["coinbasetxn"]
AssertionError
2023-11-23T14:51:16.887000Z TestFramework (INFO): Stopping nodes
2023-11-23T14:51:17.239000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20231123_144745/abc_mining_stakingrewards_67
2023-11-23T14:51:17.239000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20231123_144745/abc_mining_stakingrewards_67/test_framework.log
2023-11-23T14:51:17.239000Z TestFramework (ERROR): 
2023-11-23T14:51:17.239000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20231123_144745/abc_mining_stakingrewards_67' to consolidate all logs
2023-11-23T14:51:17.239000Z TestFramework (ERROR): 
2023-11-23T14:51:17.239000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2023-11-23T14:51:17.239000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2023-11-23T14:51:17.239000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: abc_mining_stakingrewards.py ======

------- Stdout: -------
2023-11-23T14:56:23.214000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20231123_145315/abc_mining_stakingrewards_67
2023-11-23T14:56:25.479000Z TestFramework (INFO): Staking rewards not ready yet, check getblocktemplate lacks the staking rewards data
2023-11-23T14:56:25.480000Z TestFramework (INFO): Staking rewards not ready yet, check the miner doesn't produce the staking rewards output
2023-11-23T14:56:25.487000Z TestFramework (INFO): Staking rewards are computed, check the block template returns the staking rewards data
2023-11-23T14:56:27.992000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 142, in main
    self.run_test()
  File "/work/test/functional/abc_mining_stakingrewards.py", line 144, in run_test
    assert "stakingrewards" in gbt["coinbasetxn"]
AssertionError
2023-11-23T14:56:28.043000Z TestFramework (INFO): Stopping nodes
2023-11-23T14:56:28.145000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20231123_145315/abc_mining_stakingrewards_67
2023-11-23T14:56:28.145000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20231123_145315/abc_mining_stakingrewards_67/test_framework.log
2023-11-23T14:56:28.145000Z TestFramework (ERROR): 
2023-11-23T14:56:28.146000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20231123_145315/abc_mining_stakingrewards_67' to consolidate all logs
2023-11-23T14:56:28.146000Z TestFramework (ERROR): 
2023-11-23T14:56:28.146000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2023-11-23T14:56:28.146000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2023-11-23T14:56:28.147000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_mining_stakingrewards.py
Bitcoin ABC functional tests with the next upgrade activated: abc_mining_stakingrewards.py

This revision is now accepted and ready to land.Nov 23 2023, 15:47
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

@bot build-ibd-no-assumevalid-checkpoint