Paths

Table of Contentst

Differential D14878

use cached most recent compact block when available
ClosedPublic
Actions

Authored by PiRK on Nov 30 2023, 08:03.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCcff0f65aaae2: use cached most recent compact block when available

Summary

We lost the m_most_recent_compact_block optimization when removing segwit, because in Core's codebase it used to be gated by state.fWantsCmpctWitness. See rABCf7a1e4adc8a9 and D2620.
As a result m_most_recent_compact_block is computed but unused. Make use of it.

This brings our codebase in line with Bitcoin Core's codebase just before core#24062 (next backport)

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 30 2023, 08:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2023, 08:03

PiRK requested review of this revision.Nov 30 2023, 08:03

teamcity edited the summary of this revision. (Show Details)Nov 30 2023, 08:03

Harbormaster completed remote builds in B25777: Diff 43327.Nov 30 2023, 08:22

Fabien accepted this revision.Nov 30 2023, 09:11

This revision is now accepted and ready to land.Nov 30 2023, 09:11

PiRK edited the summary of this revision. (Show Details)Nov 30 2023, 10:23

PiRK added a child revision: D14880: refactor: replace RecursiveMutex m_most_recent_block_mutex with Mutex.

Closed by commit rABCcff0f65aaae2: use cached most recent compact block when available (authored by PiRK). · Explain WhyDec 1 2023, 09:22

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCcff0f65aaae2: use cached most recent compact block when available.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

23 lines

Diff 43340

src/net_processing.cpp

Loading...