[Cashtab][Alias] Open the pending aliases dropdown by default
ClosedPublic
Actions

Authored by emack on Dec 1 2023, 08:03.

Details

Reviewers

bytesofman
Fabien

Group Reviewers

Restricted Project

Commits

Summary

As per UAT feedback in T3363, this diff opens the pending aliases dropdown by default.

Test Plan

Navigate to Alias.js, observe the pending aliases dropdown is open.

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

emack created this revision.Dec 1 2023, 08:03

emack requested review of this revision.Dec 1 2023, 08:03

Fabien requested changes to this revision.Dec 1 2023, 09:25

Fabien added a subscriber: Fabien.

Fabien added inline comments.

cashtab/src/components/Alias/__tests__/__snapshots__/Alias.test.js.snap
1 ↗	(On Diff #43339)	Please keep the generated mark if it's a generated file

This revision now requires changes to proceed.Dec 1 2023, 09:25

Adding the generated tag back into snapshot

cashtab/src/components/Alias/__tests__/__snapshots__/Alias.test.js.snap
1 ↗	(On Diff #43339)	will get this automated. I have been removing this tag according to these best practices: https://jestjs.io/docs/snapshot-testing#best-practices The files are indeed generated. However, we should be doing a sanity check to make sure the updated snapshot matches the code change. The point of the snapshots is to track changes that break components. So, we want to make sure that they failed bc an update was required, not for some other reason. So -- for now, when I add automation, I do not plan to add the `// @generated`