As per UAT feedback in T3363, this diff opens the pending aliases dropdown by default.
Details
Details
- Reviewers
bytesofman Fabien - Group Reviewers
Restricted Project - Commits
- rABC90dc50de1e1f: [Cashtab][Alias] Open the pending aliases dropdown by default
Navigate to Alias.js, observe the pending aliases dropdown is open.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- pendingListOpen
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 25786 Build 51152: Build Diff cashtab-tests Build 51151: arc lint + arc unit
Event Timeline
| cashtab/src/components/Alias/__tests__/__snapshots__/Alias.test.js.snap | ||
|---|---|---|
| 1 | Please keep the generated mark if it's a generated file | |
| cashtab/src/components/Alias/__tests__/__snapshots__/Alias.test.js.snap | ||
|---|---|---|
| 1 | will get this automated. I have been removing this tag according to these best practices: https://jestjs.io/docs/snapshot-testing#best-practices The files are indeed generated. However, we should be doing a sanity check to make sure the updated snapshot matches the code change. The point of the snapshots is to track changes that break components. So, we want to make sure that they failed bc an update was required, not for some other reason. So -- for now, when I add automation, I do not plan to add the // @generated | |
| cashtab/src/components/Alias/__tests__/__snapshots__/Alias.test.js.snap | ||
|---|---|---|
| 1 |
Isn't it the job of the tests ? | |