Page MenuHomePhabricator
Differential D14894

sync.h: Imply negative assertions when calling LOCK
ClosedPublic
Actions

Authored by PiRK on Dec 1 2023, 13:19.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCdd4d292cfdf9: sync.h: Imply negative assertions when calling LOCK
Summary

This is a partial backport of core#24931
https://github.com/bitcoin/bitcoin/pull/24931/commits/d2852917eecad6ab422a7b2c9892d351a7f0cc96

Depends on D14893

Test Plan
cmake .. -GNinja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++
ninja all check-alli

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 1 2023, 13:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 1 2023, 13:19
teamcity edited the summary of this revision. (Show Details)Dec 1 2023, 13:19
PiRK mentioned this in D14892: propagate negative thread safety annotations for avalanche code.Dec 1 2023, 13:19
PiRK mentioned this in D14891: thread safety annotation for m_tx_relay_mutex and m_cached_tip_mutex.
PiRK added a child revision: D14895: doc: Update developer notes.Dec 1 2023, 13:21
PiRK published this revision for review.Dec 1 2023, 13:22
Harbormaster completed remote builds in B25795: Diff 43350.Dec 1 2023, 13:57
Fabien accepted this revision.Dec 1 2023, 20:01
This revision is now accepted and ready to land.Dec 1 2023, 20:01
PiRK mentioned this in D14893: sync.h: Add GlobalMutex type.Dec 1 2023, 21:05
Closed by commit rABCdd4d292cfdf9: sync.h: Imply negative assertions when calling LOCK (authored by Anthony Towns <aj@erisian.com.au>, committed by PiRK). · Explain WhyDec 4 2023, 06:56
This revision was automatically updated to reflect the committed changes.
PiRK mentioned this in rABC86fc2d0d845d: thread safety annotation for m_tx_relay_mutex and m_cached_tip_mutex.
PiRK mentioned this in rABCb116942ecd84: propagate negative thread safety annotations for avalanche code.
PiRK added a commit: rABCdd4d292cfdf9: sync.h: Imply negative assertions when calling LOCK.

Revision Contents
Changeset List

PathSize
src/
52 lines

Diff 43375

View Options

src/sync.h

Loading...