[avalanche] fix timestamp flakiness in abc_p2p_avalanche_remote_proofs.py
ClosedPublic
Actions

Authored by PiRK on Dec 13 2023, 10:04.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC0e6b34d46091: [avalanche] fix timestamp flakiness in abc_p2p_avalanche_remote_proofs.py

Summary

The remote proofs returned by the getremoteproof RPC contain a "last_update" timestamp. To ensure the comparison between the expected and actual remote proofs does not fail because of a short timing issue, we need to ensure the inbound connection is added after the mocktime is set for the node.

The inbound connections are used for remote proofs since D14961.

Test Plan

alias testr="~/dev/bitcoin-abc/build/test/functional/test_runner.py"
for i in {0..20}; do  testr abc_p2p_avalanche_remote* ; done

Diff Detail

Repository

rABC Bitcoin ABC

Branch

flaky_abc_p2p_avalanche_remote_proofs

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25954
Build 51483: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 51482: arc lint + arc unit