[avalanche] fix timestamp flakiness in abc_p2p_avalanche_remote_proofs.py
ClosedPublic
Actions

Authored by PiRK on Dec 13 2023, 10:04.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC0e6b34d46091: [avalanche] fix timestamp flakiness in abc_p2p_avalanche_remote_proofs.py

Summary

The remote proofs returned by the getremoteproof RPC contain a "last_update" timestamp. To ensure the comparison between the expected and actual remote proofs does not fail because of a short timing issue, we need to ensure the inbound connection is added after the mocktime is set for the node.

The inbound connections are used for remote proofs since D14961.

Test Plan

alias testr="~/dev/bitcoin-abc/build/test/functional/test_runner.py"
for i in {0..20}; do  testr abc_p2p_avalanche_remote* ; done

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 13 2023, 10:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 13 2023, 10:04

PiRK requested review of this revision.Dec 13 2023, 10:04

Harbormaster completed remote builds in B25954: Diff 43602.Dec 13 2023, 10:30

Fabien accepted this revision.Dec 13 2023, 10:31

This revision is now accepted and ready to land.Dec 13 2023, 10:31

Closed by commit rABC0e6b34d46091: [avalanche] fix timestamp flakiness in abc_p2p_avalanche_remote_proofs.py (authored by PiRK). · Explain WhyDec 13 2023, 10:34

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC0e6b34d46091: [avalanche] fix timestamp flakiness in abc_p2p_avalanche_remote_proofs.py.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_avalanche_remote_proofs.py

4 lines

Diff 43604

View Options

test/functional/abc_p2p_avalanche_remote_proofs.py

[avalanche] fix timestamp flakiness in abc_p2p_avalanche_remote_proofs.pyClosedPublicActions